Change in vdsm[ovirt-3.6]: netinfo: report DHCP on devices only when configured (like f...

ybronhei at redhat.com ybronhei at redhat.com
Sun Sep 20 11:16:49 UTC 2015


Yaniv Bronhaim has submitted this change and it was merged.

Change subject: netinfo: report DHCP on devices only when configured (like for networks)
......................................................................


netinfo: report DHCP on devices only when configured (like for networks)

As reporting of DHCP relies on reading of dhclient lease files, it is not
reliable when a network is reconfigured to static addressing: unused leases
indicate dhclient presence hours after it has been stopped (expiration time
is usually in hours or days).

The false indication has already been fixed for networks, now even their
respective devices adhere to configuration to stop false positives.

A year and half ago it was suggested first to rely on cmdlines on running
dhclients (where network device is the last parameter for all network
configurators). This fix is just a hacky, though little bandaid for the 3.6
release. A proper fix will be considered for the 4.0 branch.

testSetupNetworksAddDelDhcp now checks that DHCP stops being reported
on a network device, in addition to its network.

Change-Id: I2b17b0c66e3a0fc8c5ada62d166d9a2b92513033
Bug-Url: https://bugzilla.redhat.com/1184497
Signed-off-by: Ondřej Svoboda <osvoboda at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/45504
Continuous-Integration: Jenkins CI
Tested-by: Eliraz Levi <elevi at redhat.com>
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/46247
Reviewed-by: Ido Barkan <ibarkan at redhat.com>
---
M lib/vdsm/netinfo.py
M tests/functional/networkTests.py
2 files changed, 59 insertions(+), 33 deletions(-)

Approvals:
  Ido Barkan: Looks good to me, but someone else must approve
  Ondřej Svoboda: Verified
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/46247
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2b17b0c66e3a0fc8c5ada62d166d9a2b92513033
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org


More information about the vdsm-patches mailing list