Change in vdsm[master]: vm: sercon: serial config must match console's

danken at redhat.com danken at redhat.com
Sat Sep 19 20:15:46 UTC 2015


Dan Kenigsberg has submitted this change and it was merged.

Change subject: vm: sercon: serial config must match console's
......................................................................


vm: sercon: serial config must match console's

When we add a serial console device, we also
inject a matching serial device.

Until now, the code assumed that the serial console has to be
bind to a PTY, while we can also bind it to an UNIX domain socket
(required by oVirt 3.6 "guest serial console" feature).

This patch makes sure that the injected serial device is bound
to the appropriate host endpoint, either pty or unix domain socket.
Please note that if the mismatch the serial device and the console
device configuration, the VM fails to start.

Change-Id: I49489a76517975fc40a226d2529bdd9f8d8c969c
Bug-Url: https://bugzilla.redhat.com/1223671
Signed-off-by: Francesco Romani <fromani at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/46187
Reviewed-by: Martin Polednik <mpolednik at redhat.com>
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M tests/vmTests.py
M vdsm/virt/vmdevices/core.py
2 files changed, 24 insertions(+), 1 deletion(-)

Approvals:
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved
  Francesco Romani: Verified
  Martin Polednik: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/46187
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I49489a76517975fc40a226d2529bdd9f8d8c969c
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: automation at ovirt.org


More information about the vdsm-patches mailing list