Change in vdsm[ovirt-3.6]: virt: vm with port mirroring stuck in down state

ybronhei at redhat.com ybronhei at redhat.com
Sat Sep 19 17:08:31 UTC 2015


Yaniv Bronhaim has submitted this change and it was merged.

Change subject: virt: vm with port mirroring  stuck in down state
......................................................................


virt: vm with port mirroring  stuck in down state

When powering off VM with port mirroring enabled the
VM id down in the UI but stuck in down state in vdsm.

The problem was that the 'tc' command was invoked
twice when a vm was shutdown from the cli. The first
time as a result of a libvirt life cycle event which
deleted the qdisc entries for the vm, the second time
it was invoked by the engine and failed as the qdisc
entries were no longer there.
The code invoking tc was moved to be after the if
statement checking if the vm has already been released.

Change-Id: Ia43369f584f696f1387685ec8f4fc4b6f58d98a6
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1254713
Signed-off-by: Marcin Mirecki <mmirecki at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/45344
Continuous-Integration: Jenkins CI
Reviewed-by: Francesco Romani <fromani at redhat.com>
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/46394
---
M vdsm/virt/vm.py
1 file changed, 9 insertions(+), 7 deletions(-)

Approvals:
  Marcin Mirecki: Verified
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/46394
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia43369f584f696f1387685ec8f4fc4b6f58d98a6
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Marcin Mirecki <mmirecki at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org


More information about the vdsm-patches mailing list