Change in vdsm[ovirt-3.5]: ifcfg: only determine and write HWADDR in removeNic if enabled

fromani at redhat.com fromani at redhat.com
Fri Sep 18 16:14:36 UTC 2015


Francesco Romani has submitted this change and it was merged.

Change subject: ifcfg: only determine and write HWADDR in removeNic if enabled
......................................................................


ifcfg: only determine and write HWADDR in removeNic if enabled

Writing of HWADDR has been deprecated for long now but for compatibility
with pre-1.0 NetworkManager (that matches on HWADDR in order to accept
NM_CONTROLLED=no) we shall still write it if requested with
hwaddr_in_ifcfg=always in vdsm.conf. This patch makes removeNic follow
suit -- addNic was alone in respecting the condition.

For more information refer to http://gerrit.ovirt.org/22288 and
https://bugzilla.redhat.com/1044060

Change-Id: Ieb4e7cdae83998b4102e79b7cb548ed95f672433
Bug-Url: https://bugzilla.redhat.com/1263979
Signed-off-by: Ondřej Svoboda <osvoboda at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/45983
Continuous-Integration: Jenkins CI
Reviewed-by: Ido Barkan <ibarkan at redhat.com>
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/46303
Continuous-Integration: Francesco Romani <fromani at redhat.com>
Tested-by: Francesco Romani <fromani at redhat.com>
Reviewed-by: Francesco Romani <fromani at redhat.com>
---
M vdsm/network/configurators/ifcfg.py
1 file changed, 16 insertions(+), 9 deletions(-)

Approvals:
  Ondřej Svoboda: Verified
  Francesco Romani: Verified; Looks good to me, approved; Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/46303
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ieb4e7cdae83998b4102e79b7cb548ed95f672433
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: automation at ovirt.org


More information about the vdsm-patches mailing list