Change in vdsm[master]: storage: skip test_mkIsoFs on MountError 'failed to setup lo...

nsoffer at redhat.com nsoffer at redhat.com
Thu Sep 17 22:46:54 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: storage: skip test_mkIsoFs on MountError 'failed to setup loop device'
......................................................................


Patch Set 3: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/46244/3/tests/mkimageTests.py
File tests/mkimageTests.py:

Line 192:         except storage.mount.MountError as me:
Line 193:             if me[0] != errno.EPIPE:
Line 194:                 raise
Line 195:             raise SkipTest("Error mounting %r at %r: %s" %
Line 196:                            (iso_img, self.workdir, me))
Sorry this test is too broken, not cleaning up properly. This fix is not enough.

Just mark this test with @brokentest("description...")  until I have time to rewrite it.
Line 197:         try:
Line 198:             self._check_content()
Line 199:             self._check_label(iso_img, label)
Line 200:             self._check_permissions(iso_img,


-- 
To view, visit https://gerrit.ovirt.org/46244
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9c69ea8beca0cab768ca84ef62b846b4f7dd1745
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list