Change in vdsm[master]: netinfo:Report host DNSs in getVdsCaps

phoracek at redhat.com phoracek at redhat.com
Thu Sep 17 21:25:31 UTC 2015


Petr Horáček has posted comments on this change.

Change subject: netinfo:Report host DNSs in getVdsCaps
......................................................................


Patch Set 3: Code-Review-1

(1 comment)

just a nit i am not sure about

https://gerrit.ovirt.org/#/c/46233/3/vdsm/rpc/vdsmapi-schema.json
File vdsm/rpc/vdsmapi-schema.json:

Line 1272: # @additionalFeatures:  Provides a list of additional features
Line 1273: #                       supported in this host.
Line 1274: #                       (new in version 4.17.0)
Line 1275: #
Line 1276: # @dnss:                Provides host DNS servers from /etc/resolve.conf
maybe we should say "(new in version xxx)" here too?
Line 1277: #
Line 1278: # Since: 4.17.0
Line 1279: #
Line 1280: # Notes: Since ovirt-engine cannot parse software versions in 'x.y.z' format,


-- 
To view, visit https://gerrit.ovirt.org/46233
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I45bb4aec72cbcf4cc6131fd829ff8cb1d8fa4403
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Meni Yakove <myakove at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Meni Yakove <myakove at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list