Change in vdsm[master]: schema: rpm for jsonrpc schema files

ybronhei at redhat.com ybronhei at redhat.com
Thu Sep 17 17:04:29 UTC 2015


Yaniv Bronhaim has posted comments on this change.

Change subject: schema: rpm for jsonrpc schema files
......................................................................


Patch Set 3:

(2 comments)

https://gerrit.ovirt.org/#/c/45750/3/vdsm.spec.in
File vdsm.spec.in:

Line 1353: %files api
Line 1354: %doc lib/api/vdsm-api.html
Line 1355: %{_datadir}/%{vdsm_name}/rpc/vdsmapi-schema.json
Line 1356: %{python_sitelib}/api/vdsmapi.py*
Line 1357: %{python_sitelib}/api/__init__.py*
> Where do you see %{python_sitelib}/%{vdsm_name}?
it should be there .. site-packages/api sounds odd? what api? api package?
Line 1358: %if ! 0%{?with_gluster}
Line 1359: %exclude %{_datadir}/%{vdsm_name}/rpc/vdsmapi-gluster-schema.json
Line 1360: %endif
Line 1361: 


Line 1362: %files yajsonrpc
Line 1363: %dir %{python_sitelib}/yajsonrpc
Line 1364: %{python_sitelib}/yajsonrpc/betterAsyncore.py*
Line 1365: %{python_sitelib}/yajsonrpc/stomp.py*
Line 1366: %{python_sitelib}/yajsonrpc/stompreactor.py*
> What do you mean?
do you intentionally want it out of vdsm packages? why? I'd expect it be also under vdsm as vdsm subpackage..
Line 1367: 
Line 1368: %files infra
Line 1369: %{python_sitelib}/%{vdsm_name}/infra/eventfd/__init__.py*
Line 1370: %{python_sitelib}/%{vdsm_name}/infra/filecontrol/__init__.py*


-- 
To view, visit https://gerrit.ovirt.org/45750
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I13d6291ddbf5bf7d8e6a0956db3300cd0c45e563
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list