Change in vdsm[master]: host stats: Collect stats from online cpu cores only

fromani at redhat.com fromani at redhat.com
Thu Sep 17 16:04:41 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: host stats: Collect stats from online cpu cores only
......................................................................


Patch Set 4: Code-Review-1

(2 comments)

let's try to simplify the tests. Codewise looks good.

https://gerrit.ovirt.org/#/c/46269/4/tests/samplingTests.py
File tests/samplingTests.py:

Line 323:                     'cpus': [1]
Line 324:                 }
Line 325:             }
Line 326:         return MonkeyPatchScope([(caps, 'getNumaTopology',
Line 327:                                 fakeNumaTopology)])
unless you have a clear case for this (please elaborate), I'd like to:
- have fakeNumaTopology as module level function, or maybe added to vmfakelib.py
- use MonkeyPatchScope inline, getting rid of this helper.
Line 328: 
Line 329:     def _expectedResult(self, node_index=0):
Line 330:         return {
Line 331:             str(node_index): {


Line 333:                 'cpuSys': '0.00',
Line 334:                 'cpuUser': '0.00',
Line 335:                 'nodeIndex': node_index
Line 336:             }
Line 337:         }
same, please inline
Line 338: 
Line 339:     def testCpuCoreStats(self):
Line 340:         cpu_sample = {'user': 1.0, 'sys': 2.0}
Line 341: 


-- 
To view, visit https://gerrit.ovirt.org/46269
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia9c247f9138e02a9230a0849a04cb2e1705e7fac
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Roman Mohr <rmohr at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list