Change in vdsm[ovirt-3.6]: ifcfg: make removeNic cope with a missing ifcfg file

ybronhei at redhat.com ybronhei at redhat.com
Thu Sep 17 15:18:38 UTC 2015


Yaniv Bronhaim has submitted this change and it was merged.

Change subject: ifcfg: make removeNic cope with a missing ifcfg file
......................................................................


ifcfg: make removeNic cope with a missing ifcfg file

For 3.6 we need to determine HWADDR property. If an ifcfg file is
not found, HWADDR is read from the system.

l.append('NM_CONTROLLED=no\n') is now used instead of
l += 'NM_CONTROLLED=no\n' with no functional change.

Change-Id: Ica18b30d508224903e7dcb898d74ae8ec35d4a23
Signed-off-by: Ondřej Svoboda <osvoboda at redhat.com>
Bug-Url: https://bugzilla.redhat.com/1256252
Reviewed-on: https://gerrit.ovirt.org/45932
Reviewed-by: Ido Barkan <ibarkan at redhat.com>
Reviewed-by: Yaniv Bronhaim <ybronhei at redhat.com>
Continuous-Integration: Yaniv Bronhaim <ybronhei at redhat.com>
---
M vdsm/network/configurators/ifcfg.py
1 file changed, 13 insertions(+), 3 deletions(-)

Approvals:
  Ido Barkan: Looks good to me, but someone else must approve
  Yaniv Bronhaim: Looks good to me, approved; Passed CI tests
  Ondřej Svoboda: Verified



-- 
To view, visit https://gerrit.ovirt.org/45932
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ica18b30d508224903e7dcb898d74ae8ec35d4a23
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Michael Burman <mburman at redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org


More information about the vdsm-patches mailing list