Change in vdsm[ovirt-3.6]: multipath: Replace specific device sections with all_devs se...

fromani at redhat.com fromani at redhat.com
Thu Sep 17 14:13:52 UTC 2015


Francesco Romani has submitted this change and it was merged.

Change subject: multipath: Replace specific device sections with all_devs section
......................................................................


multipath: Replace specific device sections with all_devs section

We require "no_path_retry fail" setting to ensure that io requests are
not queued, which may lead to blocking of multiple unrelated threads in
vdsm when performing lvm, multipath or scsi rescan operations.

We had several specific device sections, overriding "no_path_retry", but
these settings had to copy the built-in device settings, and if the
built-in settings are changed, our copied version would hide the changed
settings.

multipath supports now a new "all_devs yes" device attribute. A device
section using this attribute overrides any setting defined in the
built-in devices. Unlike regular device setting, we don't need to copy
the setting from the built-in devices, so new settings in multipathd are
respected.

This patch removes the specific device settings and replace them with
magic all_devs section.

This change also fixes the device sections for "COMPELNT/Compellent Vol"
(BZ1225162) and "HITACHI"/"DF.*" devices, which were missing the
built-in device settings. Using all_devs device, we inherit the built-in
settings we do not override.

Since this change fixes a very important bug, we also bump the revision
tag, forcing a configuration during upgrades.

Note: all_devs is not supported yet in Fedora 21 (BZ1253799). Users on
Fedora 21 may need to add specific device configuration manually for
optimal configuration.

Change-Id: If035b10558f8df37969ee694bfebd48068d2ee38
Backport-To: 3.6
Backport-To: 3.5
Bug-Url: https://bugzilla.redhat.com/880738
Bug-Url: https://bugzilla.redhat.com/1225162
Signed-off-by: Nir Soffer <nsoffer at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/44855
Continuous-Integration: Jenkins CI
Reviewed-by: Allon Mureinik <amureini at redhat.com>
Reviewed-by: Adam Litke <alitke at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/45735
Reviewed-by: Francesco Romani <fromani at redhat.com>
---
M lib/vdsm/tool/configurators/multipath.py
1 file changed, 9 insertions(+), 22 deletions(-)

Approvals:
  Nir Soffer: Verified
  Jenkins CI: Passed CI tests
  Francesco Romani: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/45735
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If035b10558f8df37969ee694bfebd48068d2ee38
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org


More information about the vdsm-patches mailing list