Change in vdsm[ovirt-3.6]: multipath: Remove unneeded "features" configuration

fromani at redhat.com fromani at redhat.com
Thu Sep 17 14:13:37 UTC 2015


Francesco Romani has submitted this change and it was merged.

Change subject: multipath: Remove unneeded "features" configuration
......................................................................


multipath: Remove unneeded "features" configuration

We used to override "features 0" to disable "queue_if_no_path" feature.
However, this configuration also disable other unrelated features, that
may be needed for optimal configuration.

We use "no_path_retry fail", which removes the feature
"queue_if_no_path" if it exists in the "features" option.

For example, if a built-in device is using:

    features "3 queue_if_no_path pg_init_retries 50"

When overriding "no_path_retry fail", the device features becomes:

    features "2 pg_init_retries 50"

Now we override only "no_path_retry fail" and leave "features" as is.

Change-Id: I6c77c5a3574e3dd7ec2f740e194a6e59efc46c2a
Backport-To: 3.6
Relates-To: https://bugzilla.redhat.com/880738
Signed-off-by: Nir Soffer <nsoffer at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/44943
Continuous-Integration: Jenkins CI
Reviewed-by: Adam Litke <alitke at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/45734
Reviewed-by: Francesco Romani <fromani at redhat.com>
---
M lib/vdsm/tool/configurators/multipath.py
1 file changed, 0 insertions(+), 2 deletions(-)

Approvals:
  Nir Soffer: Verified
  Jenkins CI: Passed CI tests
  Francesco Romani: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/45734
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6c77c5a3574e3dd7ec2f740e194a6e59efc46c2a
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org


More information about the vdsm-patches mailing list