Change in vdsm[master]: netinfo:Report host DNSs in getVdsCaps

ibarkan at redhat.com ibarkan at redhat.com
Thu Sep 17 11:44:13 UTC 2015


Ido Barkan has posted comments on this change.

Change subject: netinfo:Report host DNSs in getVdsCaps
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/46233/2/lib/vdsm/netinfo.py
File lib/vdsm/netinfo.py:

Line 581: 
Line 582: 
Line 583: def _dnsinfo():
Line 584:     """Get DNS servers from /etc/resolve.conf"""
Line 585:     return get_host_nameservers()
this function is not needed. just call _get_host_nameservers() directly from get().
Line 586: 
Line 587: 
Line 588: def _parse_expiry_time(expiry_time):
Line 589:     EPOCH = 'epoch '


-- 
To view, visit https://gerrit.ovirt.org/46233
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I45bb4aec72cbcf4cc6131fd829ff8cb1d8fa4403
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Meni Yakove <myakove at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Meni Yakove <myakove at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list