Change in vdsm[master]: netinfo:Report host DNSs in getVdsCapd networkTests: Check t...

ibarkan at redhat.com ibarkan at redhat.com
Wed Sep 16 14:49:10 UTC 2015


Ido Barkan has posted comments on this change.

Change subject: netinfo:Report host DNSs in getVdsCapd networkTests: Check that getVdsCaps report host DNSs
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

https://gerrit.ovirt.org/#/c/46233/1//COMMIT_MSG
Commit Message:

Line 3: AuthorDate: 2015-09-16 16:21:29 +0300
Line 4: Commit:     Meni Yakove <myakove at redhat.com>
Line 5: CommitDate: 2015-09-16 16:26:29 +0300
Line 6: 
Line 7: netinfo:Report host DNSs in getVdsCapd
getVdsCaps
Line 8: networkTests: Check that getVdsCaps report host DNSs
Line 9: 
Line 10: Change-Id: I45bb4aec72cbcf4cc6131fd829ff8cb1d8fa4403


https://gerrit.ovirt.org/#/c/46233/1/tests/functional/networkTests.py
File tests/functional/networkTests.py:

Line 2774:             self.assertNetworkDoesntExist(NETWORK_NAME)
Line 2775:             self.assertBondDoesntExist(BONDING_NAME, nics)
Line 2776: 
Line 2777:     @ValidateRunningAsRoot
Line 2778:     def test_dns_info(self):
this test is nice but it is exactly the same as the one previously added in netinfoTests.py and does tests very little code. so I suggest removing it.
Line 2779:         resolve_conf = (
Line 2780:             '# Generated by NetworkManager\n'
Line 2781:             'search example.com company.net\n'
Line 2782:             'domain example.com\n'


-- 
To view, visit https://gerrit.ovirt.org/46233
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I45bb4aec72cbcf4cc6131fd829ff8cb1d8fa4403
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Meni Yakove <myakove at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list