Change in vdsm[master]: supervdsm: only trigger 'vfio' subsystem for VFIO devices
nsoffer at redhat.com
nsoffer at redhat.com
Wed Sep 16 14:26:50 UTC 2015
Nir Soffer has posted comments on this change.
Change subject: supervdsm: only trigger 'vfio' subsystem for VFIO devices
......................................................................
Patch Set 7: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/45345/7/vdsm/supervdsmServer
File vdsm/supervdsmServer:
Line 469: try:
Line 470: udevadm.trigger(*args, **kwargs)
Line 471: except udevadm.Error as e:
Line 472: raise OSError(errno.EINVAL, 'Could not trigger change '
Line 473: 'out %s\nerr %s' % (e.out, e.err))
This duplicates code in udevTriggerMultipath - right?
If you add this helper, the current code should use it here.
Line 474:
Line 475:
Line 476: def terminate(signo, frame):
Line 477: global _running
--
To view, visit https://gerrit.ovirt.org/45345
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icb4fecbe5108a6ff7d695887e6e60df36e4874d7
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list