Change in vdsm[ovirt-3.6]: ifcfg: make removeNic cope with a missing ifcfg file

osvoboda at redhat.com osvoboda at redhat.com
Tue Sep 15 09:13:57 UTC 2015


Ondřej Svoboda has posted comments on this change.

Change subject: ifcfg: make removeNic cope with a missing ifcfg file
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/45932/2/vdsm/network/configurators/ifcfg.py
File vdsm/network/configurators/ifcfg.py:

Line 648:         try:
Line 649:             with open(cf) as nicFile:
Line 650:                 hwlines = [line for line in nicFile if line.startswith(
Line 651:                     'HWADDR=')]
Line 652:         except IOError as e:
> correct. we should explode violently if we see EPERM (or anything but ENOEN
I had it in my original patch -- I'll readd the special handling for ENOENT on master and backport it as well (so all patches are just cherry picks).
Line 653:             logging.warning("%s couldn't be read (errno %s)", cf, e.errno)
Line 654:             try:
Line 655:                 hwlines = ['HWADDR=%s\n' % netinfo.gethwaddr(nic)]
Line 656:             except IOError as e:


-- 
To view, visit https://gerrit.ovirt.org/45932
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ica18b30d508224903e7dcb898d74ae8ec35d4a23
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michael Burman <mburman at redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list