Change in vdsm[ovirt-3.5]: Limit sleep_millisecs to minimum 10

msivak at redhat.com msivak at redhat.com
Tue Sep 15 08:35:45 UTC 2015


Martin Sivák has posted comments on this change.

Change subject: Limit sleep_millisecs to minimum 10
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/46006/2/vdsm/mom.d/03-ksm.policy
File vdsm/mom.d/03-ksm.policy:

Line 46:     (Host.Control "ksm_run" 0)
Line 47:     {        # else
Line 48:         (Host.Control "ksm_run" 1)
Line 49:         (Host.Control "ksm_sleep_millisecs"
Line 50:             (max 10 (/ (* ksm_sleep_ms_baseline 16777216)
> In your commit message I can see:
Yep:

max(10, -5) -> 10 (minimal allowed value)
max(10, 500) -> 500 (still above the minimal allowed value)
Line 51:                        Host.mem_available)))
Line 52:        (if (< (Host.StatAvg "mem_free") ksm_pressure_threshold)
Line 53:             (change_npages ksm_pages_boost)
Line 54:            (change_npages ksm_pages_decay))


-- 
To view, visit https://gerrit.ovirt.org/46006
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7412ca576089f1dae2441ec39f72e7a94b3c8fc9
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Amador Pahim <apahim at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list