Change in vdsm[master]: migration: Add incoming migration semaphore

michal.skrivanek at redhat.com michal.skrivanek at redhat.com
Tue Sep 15 07:49:03 UTC 2015


Michal Skrivanek has posted comments on this change.

Change subject: migration: Add incoming migration semaphore
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/45954/2/vdsm/virt/migration.py
File vdsm/virt/migration.py:

Line 54: VIR_MIGRATE_PARAM_GRAPHICS_URI = 'graphics_uri'
Line 55: 
Line 56: 
Line 57: mig = min(config.getint('vars', 'max_incoming_migrations'),
Line 58:           caps.CpuTopology().cores())
> I wanted to remain consistent with the handling of outgoing migrations whic
I think we should follow the original logic. On small machines we don't want many incoming migrations either
Line 59: 
Line 60: incomingMigrations = threading.BoundedSemaphore(mig)
Line 61: 
Line 62: 


-- 
To view, visit https://gerrit.ovirt.org/45954
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8952f732033ed160292b11fbc0c4deac099b2b3e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list