Change in vdsm[master]: supervdsm: only trigger 'vfio' subsystem for VFIO devices

mpolednik at redhat.com mpolednik at redhat.com
Mon Sep 14 09:29:33 UTC 2015


Martin Polednik has posted comments on this change.

Change subject: supervdsm: only trigger 'vfio' subsystem for VFIO devices
......................................................................


Patch Set 5:

(1 comment)

https://gerrit.ovirt.org/#/c/45345/5/vdsm/supervdsmServer
File vdsm/supervdsmServer:

Line 313:         try:
Line 314:             udevadm.trigger(subsystem_matches=('vfio',))
Line 315:         except udevadm.Error as e:
Line 316:             raise OSError(errno.EINVAL, 'Could not trigger change '
Line 317:                           'out %s\nerr %s' % (e.out, e.err))
> Please move this helper bellow the functions using it. It is not related to
What is the point of scattering the trigger functions around? One more is coming and it's similar - we would have 3 lookalike pieces of code scattered around the file.
Line 318: 
Line 319:     @logDecorator
Line 320:     def appropriateMultipathDevice(self, guid, thiefId):
Line 321:         ruleFile = _UDEV_RULE_FILE_NAME % (guid, thiefId)


-- 
To view, visit https://gerrit.ovirt.org/45345
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icb4fecbe5108a6ff7d695887e6e60df36e4874d7
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list