Change in vdsm[master]: network: add ifcfg write hook

danken at redhat.com danken at redhat.com
Mon Sep 14 06:44:08 UTC 2015


Dan Kenigsberg has posted comments on this change.

Change subject: network: add ifcfg write hook
......................................................................


Patch Set 5:

(1 comment)

https://gerrit.ovirt.org/#/c/44552/5/vdsm/hooks.py
File vdsm/hooks.py:

Line 395:     return _runHooksDir(hook_dict, 'before_ifcfg_write', raiseError=False,
Line 396:                         hookType=_JSON_HOOK)
Line 397: 
Line 398: 
Line 399: def after_ifcfg_write(hook_dict):
> I gave it a little thought and I think it might be useful. Some use cases f
you really like symmetry, don't you ;-)
Line 400:     return _runHooksDir(hook_dict, 'after_ifcfg_write', raiseError=False,
Line 401:                         hookType=_JSON_HOOK)
Line 402: 
Line 403: 


-- 
To view, visit https://gerrit.ovirt.org/44552
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2206ccf97b210bd58f03777d4ccd016785b02939
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki <mmirecki at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list