Change in vdsm[master]: scale: limit cpu usage using cpu-affinity
nsoffer at redhat.com
nsoffer at redhat.com
Sun Sep 13 19:34:24 UTC 2015
Nir Soffer has posted comments on this change.
Change subject: scale: limit cpu usage using cpu-affinity
......................................................................
Patch Set 14:
(2 comments)
https://gerrit.ovirt.org/#/c/45738/14/tests/tasksetTests.py
File tests/tasksetTests.py:
Line 62: self.proc = multiprocessing.Process(target=_run_helper)
Line 63: self.proc.start()
Line 64: self.assertTrue(self.running.wait(0.5))
Line 65:
Line 66: cpu_list = ['1']
This wil fail if running on vm with single cpu, better pin to cpu 0 (same in all tests).
Line 67: taskset.set(self.proc.pid, cpu_list)
Line 68: self.assertEqual(taskset.get(self.proc.pid), cpu_list)
Line 69:
Line 70: def test_set_from_child(self):
https://gerrit.ovirt.org/#/c/45738/14/vdsm.spec.in
File vdsm.spec.in:
Line 87
Line 88
Line 89
Line 90
Line 91
Lets depend on cpopen >= 1.4
--
To view, visit https://gerrit.ovirt.org/45738
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3f7f68d65eddb5a21afbc3809ea79cd1dee67984
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yaniv Kaul <ykaul at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list