Change in vdsm[master]: networkTests: normalize strings (to unicode) through json magic

ibarkan at redhat.com ibarkan at redhat.com
Sun Sep 13 06:15:01 UTC 2015


Ido Barkan has posted comments on this change.

Change subject: networkTests: normalize strings (to unicode) through json magic
......................................................................


Patch Set 4: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/45201/4/lib/vdsm/netconfpersistence.py
File lib/vdsm/netconfpersistence.py:

Line 107:         return result
Line 108: 
Line 109:     def normalize_unicode(self):
Line 110:         self.networks = json.loads(json.dumps(self.networks))
Line 111:         self.bonds = json.loads(json.dumps(self.bonds))
I am fine with leaving this logic here as long as you don't change self.network. This will further emphasize that this is a helper. so just return the result of encoded net and bonds (and maybe call it) 'as_unicode) or something like this.
Line 112: 
Line 113: 
Line 114: class Config(BaseConfig):
Line 115:     def __init__(self, savePath):


-- 
To view, visit https://gerrit.ovirt.org/45201
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6362e04189f134ad27ee4e3c1991020b2eee91aa
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list