Change in vdsm[master]: scale: limit cpu usage using cpu-affinity

nsoffer at redhat.com nsoffer at redhat.com
Fri Sep 11 21:22:56 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: scale: limit cpu usage using cpu-affinity
......................................................................


Patch Set 12: Code-Review-1 Verified-1

I tried to test it, and vdsm will not start:

# sudo -u vdsm /usr/share/vdsm/vdsm
Traceback (most recent call last):
  File "/usr/share/vdsm/vdsm", line 287, in <module>
    main()
  File "/usr/share/vdsm/vdsm", line 268, in main
    __assertSudoerPermissions()
  File "/usr/share/vdsm/vdsm", line 256, in __assertSudoerPermissions
    (stderr))
__main__.FatalError: Vdsm user could not manage to run sudo operation: (stderr: ['sudo: a password is required']). Verify sudoer rules configuration

Adding taskset to commands run with sudo breaks our sudoers rules.

For example, we have a rule to allow:

    sudo /usr/sbin/iscsiadm *

When using resetting cpu affinity, we run:

    sudo taskset -c 0-3 /usr/sbin/iscsiadm ...

Which is not allowed by the sudo rules.

sudoers rules are not powerful enough to allow optional taskset call,
so this direction is blocked.

We should go back to the cpopen patch for disabling cpu affinity.

This patch can remain basically the same except removal of cmdutils.taskset helper.

-- 
To view, visit https://gerrit.ovirt.org/45738
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3f7f68d65eddb5a21afbc3809ea79cd1dee67984
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: No


More information about the vdsm-patches mailing list