Change in vdsm[master]: ssl: runtime config to choose implementation

piotr.kliczewski at gmail.com piotr.kliczewski at gmail.com
Fri Sep 11 15:18:01 UTC 2015


Piotr Kliczewski has posted comments on this change.

Change subject: ssl: runtime config to choose implementation
......................................................................


Patch Set 7:

(2 comments)

https://gerrit.ovirt.org/#/c/44689/7/lib/vdsm/sslcompat.py
File lib/vdsm/sslcompat.py:

Line 37: 
Line 38:     # we need it to satisfy pyflakes
Line 39:     sslutils
Line 40:     SSLHandshakeDispatcher
Line 41:     SSLSocket
> does pyflakes complain if you remove this...
Yes, that is way I had to add it here.
Line 42: 
Line 43: if _USED_IMPLEMENTATION is None:
Line 44:     from . import sslutils
Line 45:     from .sslutils import SSLHandshakeDispatcher


Line 47: 
Line 48:     # we need it to satisfy pyflakes
Line 49:     sslutils
Line 50:     SSLHandshakeDispatcher
Line 51:     SSLSocket
> ...and deindent this?
It is required as well. Without it the build fails....


-- 
To view, visit https://gerrit.ovirt.org/44689
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9881d11e30ced9c34bfe602bba3d968f57e0fe15
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list