Change in vdsm[master]: sp: deactivateSd - remove domain from pending for upgrade list

nsoffer at redhat.com nsoffer at redhat.com
Thu Sep 10 16:11:25 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: sp: deactivateSd - remove domain from pending for upgrade list
......................................................................


Patch Set 14:

(1 comment)

https://gerrit.ovirt.org/#/c/45773/14/vdsm/storage/sp.py
File vdsm/storage/sp.py:

Line 1110:         try:
Line 1111:             self._domainsToUpgrade.remove(sdUUID)
Line 1112:         except ValueError:
Line 1113:             pass
Line 1114:         else:
> we can eliminate the else and instead return on ValueError, Nir - please te
It is ok as is.
Line 1115:             self._finalizePoolUpgradeIfNeeded()
Line 1116: 
Line 1117:     def _finalizePoolUpgradeIfNeeded(self):
Line 1118:         if len(self._domainsToUpgrade) == 0:


-- 
To view, visit https://gerrit.ovirt.org/45773
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4451b348b8837dd83d95aea2be4a4536b33cdd99
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list