Change in vdsm[master]: virt: vm with port mirroring stuck in down state

fromani at redhat.com fromani at redhat.com
Thu Sep 10 15:39:35 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: virt: vm with port mirroring  stuck in down state
......................................................................


Patch Set 4: Code-Review-1

(1 comment)

-1 for visibility
Ok, I'm now convinced that this not really improves the flow without deeper changes, out of the scope of this patch. 
It was worth a try.
Let's go back to simpler v2 and I think is good enough.

https://gerrit.ovirt.org/#/c/45344/4/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 3691:                 if hasattr(nic, 'portMirroring'):
Line 3692:                     for network in nic.portMirroring[:]:
Line 3693:                         supervdsm.getProxy().unsetPortMirroring(network,
Line 3694:                                                                 nic.name)
Line 3695:                         nic.portMirroring.remove(network)
I had a look at the code, and we need much more refactoring in that area to have cleaner code. So let's drop this attempt,
we can just move the block above here like you did in v2 and that's it.
Line 3696: 
Line 3697:             self.log.info('Release VM resources')
Line 3698:             self.lastStatus = vmstatus.POWERING_DOWN
Line 3699:             # Terminate the VM's creation thread.


-- 
To view, visit https://gerrit.ovirt.org/45344
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia43369f584f696f1387685ec8f4fc4b6f58d98a6
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki <mmirecki at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list