Change in vdsm[ovirt-3.5]: Live Merge: Allow extension of non-leaf raw volumes

fromani at redhat.com fromani at redhat.com
Thu Sep 10 13:45:01 UTC 2015


Francesco Romani has submitted this change and it was merged.

Change subject: Live Merge: Allow extension of non-leaf raw volumes
......................................................................


Live Merge: Allow extension of non-leaf raw volumes

volume.extendSize() is currently prohibited for any non-leaf volume.
For a very specific live merge scenario we must permit extension of an
internal raw base volume.  Allow this usage and add a comment explaining
the reasoning.

The scenario:
 - User begins with a raw block disk.
 - User creates a snapshot.
 - User enlarges the disk (diskSizeExtend)
 - User performs live merge to remove the snapshot

In this case the base volume is too small to accommodate the data
from the child volume and an error is raised since libvirt cannot
enlarge a block device.  The solution is to require engine to call
extendVolumeSize on the base volume before requesting the live merge
operation.

Change-Id: I82a73356a863abe39d367cdc70a9b1e914f75aee
Signed-off-by: Adam Litke <alitke at redhat.com>
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1251958
Reviewed-on: https://gerrit.ovirt.org/43407
Continuous-Integration: Jenkins CI
Reviewed-by: Nir Soffer <nsoffer at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/45948
Reviewed-by: Francesco Romani <fromani at redhat.com>
Continuous-Integration: Francesco Romani <fromani at redhat.com>
---
M vdsm/storage/volume.py
1 file changed, 9 insertions(+), 2 deletions(-)

Approvals:
  Nir Soffer: Looks good to me, but someone else must approve
  Adam Litke: Verified
  Francesco Romani: Looks good to me, approved; Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/45948
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I82a73356a863abe39d367cdc70a9b1e914f75aee
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org


More information about the vdsm-patches mailing list