Change in vdsm[master]: scale: limit cpu usage using cpu-affinity
nsoffer at redhat.com
nsoffer at redhat.com
Thu Sep 10 13:31:02 UTC 2015
Nir Soffer has posted comments on this change.
Change subject: scale: limit cpu usage using cpu-affinity
......................................................................
Patch Set 9:
(2 comments)
Partial review
https://gerrit.ovirt.org/#/c/45738/9/tests/utilsTests.py
File tests/utilsTests.py:
Line 75: self.assertEquals(counter[0], limit)
Line 76:
Line 77:
Line 78: @expandPermutations
Line 79: class PidStatTests(TestCaseBase):
> There is a tiny race on startup.
We have the same problem with nice, ionice and other modifiers, so this is not new.
For the tests, we should use only resetCpuAffinity=False, we don't care about that in the test context.
Line 80:
Line 81: @permutations([[True], [False]])
Line 82: @MonkeyPatch(utils, 'config',
Line 83: make_config([('vars', 'cpu_affinity', '1')]))
Line 79: class PidStatTests(TestCaseBase):
Line 80:
Line 81: @permutations([[True], [False]])
Line 82: @MonkeyPatch(utils, 'config',
Line 83: make_config([('vars', 'cpu_affinity', '1')]))
If we use only resetCpuAffinity=False, we don't need permutations and the extra monkeypatching.
Line 84: def test(self, reset_cpu_affinity):
Line 85: args = ["sleep", "3"]
Line 86: sproc = utils.execCmd(args,
Line 87: sync=False,
--
To view, visit https://gerrit.ovirt.org/45738
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3f7f68d65eddb5a21afbc3809ea79cd1dee67984
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list