Change in vdsm[master]: ifcfg: make removeNic cope with a missing ifcfg file

osvoboda at redhat.com osvoboda at redhat.com
Thu Sep 10 08:51:28 UTC 2015


Ondřej Svoboda has posted comments on this change.

Change subject: ifcfg: make removeNic cope with a missing ifcfg file
......................................................................


Patch Set 4:

(1 comment)

https://gerrit.ovirt.org/#/c/45893/4/vdsm/network/configurators/ifcfg.py
File vdsm/network/configurators/ifcfg.py:

Line 645:         return ipv4, ipv6, mtu
Line 646: 
Line 647:     def removeNic(self, nic):
Line 648:         cf = netinfo.NET_CONF_PREF + nic
Line 649:         self._backup(cf)
> in a follow up patch, please make this conditional on _hwaddr_required(). W
Done in https://gerrit.ovirt.org/45983
Line 650:         try:
Line 651:             with open(cf) as nicFile:
Line 652:                 hwlines = [line for line in nicFile if line.startswith(
Line 653:                     'HWADDR=')]


-- 
To view, visit https://gerrit.ovirt.org/45893
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ica18b30d508224903e7dcb898d74ae8ec35d4a23
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list