Change in vdsm[master]: scale: limit cpu usage using cpu-affinity

fromani at redhat.com fromani at redhat.com
Thu Sep 10 08:43:15 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: scale: limit cpu usage using cpu-affinity
......................................................................


Patch Set 9:

(2 comments)

https://gerrit.ovirt.org/#/c/45738/9/lib/vdsm/taskset.py
File lib/vdsm/taskset.py:

Line 41:     Get the affinity of a process, by its <pid>, using taskset command.
Line 42:     We assume all threads of the process have the same affinity, because
Line 43:     this is the only usecase VDSM cares about - and requires.
Line 44:     Return a list of strings, each one being a cpu indices on which the
Line 45:     process can run. The list must not be assumed to be ordered.
> I would remove the comment and sort the output.
Done
Line 46:     Example: ['0', '1', '2', '3']
Line 47:     Raise taskset.Error on failure.
Line 48:     """
Line 49:     command = [constants.EXT_TASKSET, '--pid', str(pid)]


Line 42:     We assume all threads of the process have the same affinity, because
Line 43:     this is the only usecase VDSM cares about - and requires.
Line 44:     Return a list of strings, each one being a cpu indices on which the
Line 45:     process can run. The list must not be assumed to be ordered.
Line 46:     Example: ['0', '1', '2', '3']
> Only if you resubmit again: The comment begs you to assume an ordered resul
Fixed the other way around like Nir suggested.
Line 47:     Raise taskset.Error on failure.
Line 48:     """
Line 49:     command = [constants.EXT_TASKSET, '--pid', str(pid)]
Line 50: 


-- 
To view, visit https://gerrit.ovirt.org/45738
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3f7f68d65eddb5a21afbc3809ea79cd1dee67984
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list