Change in vdsm[master]: vm: graphics: save all settings when snapshotting
fromani at redhat.com
fromani at redhat.com
Thu Sep 10 07:57:38 UTC 2015
Francesco Romani has uploaded a new change for review.
Change subject: vm: graphics: save all settings when snapshotting
......................................................................
vm: graphics: save all settings when snapshotting
When we prepare a snapshot, we must make sure to save all the
relevant configuration for graphics, otherwise restore will
reset the configuration, lacking instructions from VDSM.
This behaviour is easily reproduced on Centos 7.1/2 by:
a. booting a VM with SPICE graphic device
b. do a snapshot, make sure to check 'snapshot memory'
c. preview the snapshot
d. run the VM
e. check the VM parameters (e.g. qemu)
Change-Id: I919495f210827725baac07595b46173eca2f4ed7
Backport-To: 3.6
Bug-Url: https://bugzilla.redhat.com/1260177
Signed-off-by: Francesco Romani <fromani at redhat.com>
---
M vdsm/virt/vm.py
1 file changed, 6 insertions(+), 3 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/79/45979/1
diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index df8debc..db90568 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -2998,9 +2998,12 @@
def _vmConfForMemorySnapshot():
"""Returns the needed vm configuration with the memory snapshot"""
- return {'restoreFromSnapshot': True,
- '_srcDomXML': self._dom.XMLDesc(0),
- 'elapsedTimeOffset': time.time() - self._startTime}
+ return {
+ 'restoreFromSnapshot': True,
+ '_srcDomXML': self._dom.XMLDesc(
+ libvirt.VIR_DOMAIN_XML_SECURE),
+ 'elapsedTimeOffset': time.time() - self._startTime
+ }
def _padMemoryVolume(memoryVolPath, sdUUID):
sdType = sd.name2type(
--
To view, visit https://gerrit.ovirt.org/45979
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I919495f210827725baac07595b46173eca2f4ed7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
More information about the vdsm-patches
mailing list