Change in vdsm[master]: ssl: runtime config to choose implementation

ykaplan at redhat.com ykaplan at redhat.com
Wed Sep 9 12:26:25 UTC 2015


Yeela Kaplan has posted comments on this change.

Change subject: ssl: runtime config to choose implementation
......................................................................


Patch Set 6: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/44689/6/lib/vdsm/sslcompat.py
File lib/vdsm/sslcompat.py:

Line 26:     else:
Line 27:         from . import sslutils
Line 28:         from .sslutils import SSLHandshakeDispatcher
Line 29:         from ssl import SSLSocket
Line 30: except ImportError:
Could you try and do it more nicely?
maybe use a True/False variable, and set it in case of ImportError or the 'else' clause.. and only then import ssl instead of importing twice..?
Line 31:     from . import sslutils
Line 32:     from .sslutils import SSLHandshakeDispatcher
Line 33:     from ssl import SSLSocket
Line 34: 


-- 
To view, visit https://gerrit.ovirt.org/44689
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9881d11e30ced9c34bfe602bba3d968f57e0fe15
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list