Change in vdsm[master]: ssl: configurable implementation
piotr.kliczewski at gmail.com
piotr.kliczewski at gmail.com
Wed Sep 9 11:06:00 UTC 2015
Piotr Kliczewski has posted comments on this change.
Change subject: ssl: configurable implementation
......................................................................
Patch Set 8:
(3 comments)
https://gerrit.ovirt.org/#/c/44494/8/lib/vdsm/sslcompat.py
File lib/vdsm/sslcompat.py:
Line 16: # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
Line 17: #
Line 18: # Refer to the README and COPYING files for full details of the license
Line 19: #
Line 20: try:
> I'm not sure this is what Nir meant in a past comment, IIUC he suggested to
We can't use existing compat module because if we do we would create module dependency cycle.
Line 21: from . import m2cutils as sslutils
Line 22: from .m2cutils import SSLSocket
Line 23: from .m2cutils import SSLHandshakeDispatcher
Line 24: except ImportError:
Line 25: from . import sslutils
Line 26: from .sslutils import SSLHandshakeDispatcher
Line 27: from ssl import SSLSocket
Line 28:
Line 29: # we need it to satisfy pyflakes
> does this block need to be indented? Just asking, not sure about what pytho
pyflakes complains that modules are imported but not used.
Line 30: sslutils
Line 31: SSLHandshakeDispatcher
https://gerrit.ovirt.org/#/c/44494/8/lib/vdsm/sslutils.py
File lib/vdsm/sslutils.py:
Line 25: import ssl
Line 26: import xmlrpclib
Line 27:
Line 28: from vdsm.utils import (
Line 29: monotonic_time,
> no need for parens, but not that important.
Copied from m2cutils. Will change in different patch.
Line 30: )
Line 31: from .config import config
Line 32:
Line 33:
--
To view, visit https://gerrit.ovirt.org/44494
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6501981bbd5276c49731b0d9eba4794286b0f823
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list