Change in vdsm[master]: configurator doesn't load pyc files under configurators folder
ybronhei at redhat.com
ybronhei at redhat.com
Wed Sep 9 05:49:41 UTC 2015
Yaniv Bronhaim has posted comments on this change.
Change subject: configurator doesn't load pyc files under configurators folder
......................................................................
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/45846/1/lib/vdsm/tool/configurator.py
File lib/vdsm/tool/configurator.py:
Line 57: filter_ = lambda x: not x.startswith('_')
Line 58:
Line 59: return [
Line 60: getmname(module)
Line 61: for module in iglob("%s*.py*" % path)
> Good point, this should remove duplicate names before returning the result.
no order. and I like the set cast though we don't have any problem with having the same name twice, but I guess its just redundant or a waste
Line 62: if filter_(getmname(module))
Line 63: ]
Line 64:
Line 65:
--
To view, visit https://gerrit.ovirt.org/45846
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia529de0069e2f4ec168a4b9df82ba62c56d66730
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list