Change in vdsm[master]: ifcfg: make removeNic cope with a missing ifcfg file

osvoboda at redhat.com osvoboda at redhat.com
Tue Sep 8 21:44:27 UTC 2015


Ondřej Svoboda has posted comments on this change.

Change subject: ifcfg: make removeNic cope with a missing ifcfg file
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

Exception handling is maybe too granular for no benefit (but errno should still be logged).

https://gerrit.ovirt.org/#/c/45893/1/vdsm/network/configurators/ifcfg.py
File vdsm/network/configurators/ifcfg.py:

Line 660: logging.warning("%s didn't exist, HWADDR is unknown", cf)
        :             else:
        :                 logging.exception("%s couldn't be read, HWADDR is unknown", cf)
Okay, this is wasteful.


-- 
To view, visit https://gerrit.ovirt.org/45893
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ica18b30d508224903e7dcb898d74ae8ec35d4a23
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list