Change in vdsm[ovirt-3.6]: revert "storage: validate vdsm rwx permissions for file stor...

gpadgett at redhat.com gpadgett at redhat.com
Tue Sep 8 21:25:40 UTC 2015


Greg Padgett has uploaded a new change for review.

Change subject: revert "storage: validate vdsm rwx permissions for file storage"
......................................................................

revert "storage: validate vdsm rwx permissions for file storage"

This reverts commit 777c36d64f9fe0aee69fe6ed9049262accff54d3

The above patch triggers a race condition in supervdsm's _runAs()
method which can prevent file-based storage domains from being added,
thus this patch needs to be reverted.

Change-Id: I2a602a08d0588af13d44947faf054d88ea9acc5f
Bug-Url: https://bugzilla.redhat.com/1259310
Related-To: https://bugzilla.redhat.com/1250752
Signed-off-by: Greg Padgett <gpadgett at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/45891
Continuous-Integration: Jenkins CI
---
M vdsm/storage/fileSD.py
1 file changed, 0 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/92/45892/1

diff --git a/vdsm/storage/fileSD.py b/vdsm/storage/fileSD.py
index ec46d18..2feb6b5 100644
--- a/vdsm/storage/fileSD.py
+++ b/vdsm/storage/fileSD.py
@@ -67,10 +67,6 @@
     try:
         getProcPool().fileUtils.validateAccess(dirPath)
         supervdsm.getProxy().validateAccess(
-            constants.VDSM_USER,
-            (constants.VDSM_GROUP,), dirPath,
-            (os.R_OK | os.W_OK | os.X_OK))
-        supervdsm.getProxy().validateAccess(
             constants.QEMU_PROCESS_USER,
             (constants.DISKIMAGE_GROUP, constants.METADATA_GROUP), dirPath,
             (os.R_OK | os.X_OK))


-- 
To view, visit https://gerrit.ovirt.org/45892
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2a602a08d0588af13d44947faf054d88ea9acc5f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Greg Padgett <gpadgett at redhat.com>


More information about the vdsm-patches mailing list