Change in vdsm[master]: sp: allow executing upgradePool even if there is a pending u...
laravot at redhat.com
laravot at redhat.com
Tue Sep 8 14:07:34 UTC 2015
Liron Aravot has posted comments on this change.
Change subject: sp: allow executing upgradePool even if there is a pending update
......................................................................
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/45774/5/vdsm/storage/sp.py
File vdsm/storage/sp.py:
Line 422:
Line 423: sd.validateDomainVersion(targetDomVersion)
Line 424: try:
Line 425: self.log.info("Trying to lock domains that are currently pending for an update")
Line 426: for sdUUID in self._domainsToUpgrade:
> need to sort the domains here and in shutdownupgrade.
actually unneed, both flows take lock on the pool beforehand.
Line 427: try:
Line 428: res = rmanager.acquireResource(STORAGE, "upgrade_" + sdUUID,
Line 429: rm.LockType.exclusive)
Line 430: except (rm.RequestTimedOutError, se.ResourceAcqusitionFailed):
--
To view, visit https://gerrit.ovirt.org/45774
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3c30439b5b84f64fd2ad69d82f33dfdfc4c9ef68
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list