Change in vdsm[master]: net: ifcfg: synchronous ifup

danken at redhat.com danken at redhat.com
Tue Sep 8 07:41:45 UTC 2015


Dan Kenigsberg has submitted this change and it was merged.

Change subject: net: ifcfg: synchronous ifup
......................................................................


net: ifcfg: synchronous ifup

Return device only after it's properly created and up. Without this
check, device can be used before ready and it will end with failture.

Disadvantage of this patch is slower network configuration
(functional/networkTests.py was running 1000s instead of 700s).

Change-Id: I0c90a556f5fc52c1b8e675986ac39b6032ca0197
Signed-off-by: Petr Horáček <phoracek at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/37366
Continuous-Integration: Jenkins CI
Reviewed-by: Ido Barkan <ibarkan at redhat.com>
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M vdsm/network/configurators/ifcfg.py
1 file changed, 44 insertions(+), 1 deletion(-)

Approvals:
  Ido Barkan: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Petr Horáček: Verified
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/37366
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0c90a556f5fc52c1b8e675986ac39b6032ca0197
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org


More information about the vdsm-patches mailing list