Change in vdsm[master]: sp: startSpm - ignore InquireNotSupportedError()

nsoffer at redhat.com nsoffer at redhat.com
Mon Sep 7 16:37:55 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: sp: startSpm - ignore InquireNotSupportedError()
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/45764/1/vdsm/storage/sp.py
File vdsm/storage/sp.py:

Line 252:             try:
Line 253:                 oldlver, oldid = self._backend.getSpmStatus()
Line 254:             except se.InquireNotSupportedError:
Line 255:                 self.log.info("cluster lock inquire isn't supported. "
Line 256:                               "proceeding with startSpm()")
> Should probably be log.warn
This is an expected condition during upgrade, but vdsm does not have any context about the upgrade, so I don't think we need to warn here.
Line 257:             else:
Line 258:                 if int(oldlver) != int(prevLVER) or int(oldid) != int(prevID):
Line 259:                     self.log.info("expected previd:%s lver:%s got request for "
Line 260:                                   "previd:%s lver:%s" %


-- 
To view, visit https://gerrit.ovirt.org/45764
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I082dc83ea410768db3819e7259089c20c2614b07
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list