Change in vdsm[master]: scale: limit cpu usage using cpu-affinity
fromani at redhat.com
fromani at redhat.com
Mon Sep 7 16:10:43 UTC 2015
Francesco Romani has posted comments on this change.
Change subject: scale: limit cpu usage using cpu-affinity
......................................................................
Patch Set 6:
(2 comments)
https://gerrit.ovirt.org/#/c/45738/6/lib/vdsm/taskset.py
File lib/vdsm/taskset.py:
Line 36: self.rc, self.out, self.err)
Line 37:
Line 38:
Line 39: def get(pid, all_tasks=True):
Line 40: # TODO: check pid
> stale comment, forgot to remove.
Done
Line 41: cmd = [constants.EXT_TASKSET,
Line 42: '--all-tasks' if all_tasks else '',
Line 43: '--pid', str(pid)]
Line 44:
Line 50: return _cpu_list_from_output(out[0])
Line 51:
Line 52:
Line 53: def set(pid, cpu_list, all_tasks=True):
Line 54: # TODO: check pid
> ditto
Done
Line 55: # warning: the order of options is significant.
Line 56: cmd = [constants.EXT_TASKSET,
Line 57: '--all-tasks' if all_tasks else '',
Line 58: '--pid',
--
To view, visit https://gerrit.ovirt.org/45738
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3f7f68d65eddb5a21afbc3809ea79cd1dee67984
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list