Change in vdsm[ovirt-3.5]: net: backport cmdutils.systemd_run

danken at redhat.com danken at redhat.com
Mon Sep 7 12:46:00 UTC 2015


Dan Kenigsberg has posted comments on this change.

Change subject: net: backport cmdutils.systemd_run
......................................................................


Patch Set 5:

this seems bad, albeit unrelated to the patch

ERROR: test_parseVolumeStatus (gluster_cli_tests.GlusterCliTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/builddir/build/BUILD/vdsm-4.16.26/tests/gluster_cli_tests.py", line 1083, in test_parseVolumeStatus
    self._parseVolumeStatus_test()
  File "/builddir/build/BUILD/vdsm-4.16.26/tests/gluster_cli_tests.py", line 268, in _parseVolumeStatus_test
    status = gcli._parseVolumeStatus(tree)
  File "/builddir/build/BUILD/vdsm-4.16.26/vdsm/gluster/cli.py", line 137, in _parseVolumeStatus
    hostname = _getLocalIpAddress() or _getGlusterHostName()
  File "/builddir/build/BUILD/vdsm-4.16.26/vdsm/gluster/cli.py", line 107, in _getLocalIpAddress
    for ip in netinfo.getIpAddresses():
  File "/builddir/build/BUILD/vdsm-4.16.26/lib/vdsm/netinfo.py", line 784, in getIpAddresses
    return filter(None, [getaddr(i) for i in ethtool.get_active_devices()])
  File "/builddir/build/BUILD/vdsm-4.16.26/lib/vdsm/netinfo.py", line 300, in getaddr
    dev_info_list = ethtool.get_interfaces_info(dev.encode('utf8'))
UnicodeDecodeError: 'ascii' codec can't decode byte 0xe3 in position 5: ordinal not in range(128)

-- 
To view, visit https://gerrit.ovirt.org/43852
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7686e80c0880dcc28fa735d1dd3ab658136889f9
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: No


More information about the vdsm-patches mailing list