Change in vdsm[master]: hostdev: add udev rules for USB devices

nsoffer at redhat.com nsoffer at redhat.com
Fri Sep 4 23:55:11 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: hostdev: add udev rules for USB devices
......................................................................


Patch Set 8:

(1 comment)

https://gerrit.ovirt.org/#/c/44679/8/vdsm/supervdsmServer
File vdsm/supervdsmServer:

Line 398: 
Line 399:         self.udevTriggerUSB(bus, device)
Line 400: 
Line 401:     @logDecorator
Line 402:     def releaseAppropriateUSBDevice(self, bus, device):
> Addressed in https://gerrit.ovirt.org/#/c/45420/
I explained why we don't need this function in a previous comment in one of the patches that included it.

Please explain why we need this function which is not needed for other udev rules (we have appropriateXXXDevice and rmAppropriateXXXDevice).
Line 403:         rule_file = _UDEV_RULE_FILE_NAME_USB % (bus, device)
Line 404: 
Line 405:         rule = ('SUBSYSTEM=="usb", ATTRS{{busnum}}=="{}", '
Line 406:                 'ATTRS{{devnum}}=="{}", '


-- 
To view, visit https://gerrit.ovirt.org/44679
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1f72f63186187254cd4aded0a2e6c396001ca28b
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list