Change in vdsm[master]: Add an empty metadata qos element to the created domain

danken at redhat.com danken at redhat.com
Fri Sep 4 15:42:36 UTC 2015


Dan Kenigsberg has posted comments on this change.

Change subject: Add an empty metadata qos element to the created domain
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/45664/2/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 72: from .vmdevices.storage import DISK_TYPE
Line 73: from .vmtune import update_io_tune_dom, collect_inner_elements
Line 74: from .vmtune import io_tune_values_to_dom, io_tune_dom_to_values
Line 75: from . import vmxml
Line 76: from .vmxml import METADATA_VM_TUNE_URI, METADATA_VM_TUNE_ELEMENT, METADATA_VM_TUNE_PREFIX
why didn't pep8 cry!? we must fix the CI job.
Line 77: 
Line 78: from .utils import isVdsmImage, cleanup_guest_socket
Line 79: from vmpowerdown import VmShutdown, VmReboot
Line 80: 


-- 
To view, visit https://gerrit.ovirt.org/45664
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc5db925b55ea8e583a11d548a27dc3fd0886fee
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list