Change in vdsm[master]: lib: daemon: cpu affinity support using taskset

msivak at redhat.com msivak at redhat.com
Fri Sep 4 13:48:35 UTC 2015


Martin Sivák has posted comments on this change.

Change subject: lib: daemon: cpu affinity support using taskset
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/45738/2/lib/vdsm/config.py.in
File lib/vdsm/config.py.in:

Line 214:             'Default is empty list, meaning VDSM can be scheduled by the OS '
Line 215:             'to run on any core. '
Line 216:             'The format is list of integers from 1 to N; range syntax '
Line 217:             'like start-stop (both included) is supported. '
Line 218:             'Valid examples: "0,1", "0,2,3-5", "0,8-15,23", "0-4"')
> Too complicated, we need only one cpu for vdsm, so expecting list of cpu nu
I think we should not pin by default. Big machines commonly have hotplug and some cpus can be offline. Not good if we accidentally select the disconnected one..

And btw, the counting starts with 0. So even if we decide to use a default (not a bad idea if we do not care about offline cpus) we should use 0.
Line 219: 
Line 220:     ]),
Line 221: 
Line 222:     # Section: [mom]


-- 
To view, visit https://gerrit.ovirt.org/45738
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3f7f68d65eddb5a21afbc3809ea79cd1dee67984
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list