Change in vdsm[master]: lib: daemon: cpu affinity support using taskset
michal.skrivanek at redhat.com
michal.skrivanek at redhat.com
Fri Sep 4 09:52:06 UTC 2015
Michal Skrivanek has posted comments on this change.
Change subject: lib: daemon: cpu affinity support using taskset
......................................................................
Patch Set 1:
(2 comments)
https://gerrit.ovirt.org/#/c/45738/1/lib/vdsm/config.py.in
File lib/vdsm/config.py.in:
Line 211: ('cpu_affinity', '',
Line 212: 'CPU cores on which VDSM is forced to run. '
Line 213: 'supported format is list of integers from 1 to N; range syntax '
Line 214: 'like start-stop (both included) is supported. '
Line 215: 'Default is no affinity: VDSM is not pinned to any core, so '
> We need some option to be able to enable/disable this. And I think the use
why empty, "-1" sounds good to me
Line 216: 'it can run on any cpu core.')
Line 217:
Line 218: ]),
Line 219:
Line 211: ('cpu_affinity', '',
Line 212: 'CPU cores on which VDSM is forced to run. '
Line 213: 'supported format is list of integers from 1 to N; range syntax '
Line 214: 'like start-stop (both included) is supported. '
Line 215: 'Default is no affinity: VDSM is not pinned to any core, so '
> good point. I'll probably need more work here to make this clearer.
why not supporting only a single cpu? for the sake of simplicity
Line 216: 'it can run on any cpu core.')
Line 217:
Line 218: ]),
Line 219:
--
To view, visit https://gerrit.ovirt.org/45738
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3f7f68d65eddb5a21afbc3809ea79cd1dee67984
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list