Change in vdsm[master]: lib: daemon: cpu affinity support using taskset

fromani at redhat.com fromani at redhat.com
Thu Sep 3 17:58:40 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: lib: daemon: cpu affinity support using taskset
......................................................................


Patch Set 1:

(3 comments)

https://gerrit.ovirt.org/#/c/45738/1//COMMIT_MSG
Commit Message:

Line 17: We need a patch which is simple to backport down to 3.5,
Line 18: so we use taskset just before the start of VDSM.
Line 19: 
Line 20: taskset is part of util-linux, so no additional dependency
Line 21: is needed.
cpopen patch pending. We need to (re)set the affinity mask for external processes.
Line 22: 
Line 23: Change-Id: I3f7f68d65eddb5a21afbc3809ea79cd1dee67984
Line 24: Bug-Url: https://bugzilla.redhat.com/1247075
Line 25: Backport-To: 3.6


https://gerrit.ovirt.org/#/c/45738/1/lib/vdsm/config.py.in
File lib/vdsm/config.py.in:

Line 209:             'Time in seconds defining how frequently we log transport stats'),
Line 210: 
Line 211:         ('cpu_affinity', '',
Line 212:             'CPU cores on which VDSM is forced to run. '
Line 213:             'supported format is list of integers from 1 to N; range syntax '
'from 0 to N'
Line 214:             'like start-stop (both included) is supported. '
Line 215:             'Default is no affinity: VDSM is not pinned to any core, so '
Line 216:             'it can run on any cpu core.')
Line 217: 


https://gerrit.ovirt.org/#/c/45738/1/lib/vdsm/utils.py
File lib/vdsm/utils.py:

Line 1295:             yield int(item)
Line 1296: 
Line 1297: 
Line 1298: def cpu_mask_to_bits(cpus):
Line 1299:     mask = 0
move below at the beginning of the for loop (this isn't C :) )
Line 1300:     if not cpus:
Line 1301:         return CPU_ANY
Line 1302: 
Line 1303:     for idx in _expand_cpu_list(cpus):


-- 
To view, visit https://gerrit.ovirt.org/45738
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3f7f68d65eddb5a21afbc3809ea79cd1dee67984
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list