Change in vdsm[master]: network.api: EL7's dhclient doesn't support -df so stop usin...

osvoboda at redhat.com osvoboda at redhat.com
Thu Sep 3 10:46:26 UTC 2015


Ondřej Svoboda has posted comments on this change.

Change subject: network.api: EL7's dhclient doesn't support -df so stop using it temporarily
......................................................................


Patch Set 2:

(2 comments)

Thanks, Francesco, I'll do a revision 3 if no one else raises their objections.

https://gerrit.ovirt.org/#/c/45713/2/vdsm/network/configurators/dhclient.py
File vdsm/network/configurators/dhclient.py:

Line 70: 
Line 71:     def start(self, blocking):
Line 72:         if blocking:
Line 73:             rc, out, err = self._dhclient()
Line 74:             return rc, out, err
> maybe just
Aaah, right :-)
Line 75:         else:
Line 76:             t = threading.Thread(target=self._dhclient, name='vdsm-dhclient-%s'
Line 77:                                  % self.iface)
Line 78:             t.daemon = True


Line 137: 
Line 138: 
Line 139: @memoized
Line 140: def supports_duid_file():
Line 141:     probe = DhcpClient('-invalid-option')  # dhclient doesn't have -h/--help
> well, if it doesn't support -h/--help, then --help is as good as '-invalid-
I wouldn't be able to branch on the return code (it would be 0 once --help is implemented). I wanted to be sure this check doesn't break anytime soon.
Line 142:     rc, out, err = probe.start(blocking=True)
Line 143:     if rc:
Line 144:         for line in err:
Line 145:             if '-df' in line:


-- 
To view, visit https://gerrit.ovirt.org/45713
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia096d42d24b00e7ef075f1a2dde7e3a951c0b81c
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: David Caro <dcaroest at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki at redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list