Change in vdsm[master]: StorageDomainManifest: Move acquireVolumeMetadataSlot
nsoffer at redhat.com
nsoffer at redhat.com
Wed Sep 2 20:19:38 UTC 2015
Nir Soffer has posted comments on this change.
Change subject: StorageDomainManifest: Move acquireVolumeMetadataSlot
......................................................................
Patch Set 4: Code-Review-1
(1 comment)
Looks ok, see question about storing tags
https://gerrit.ovirt.org/#/c/45389/4/tests/storagefakelib.py
File tests/storagefakelib.py:
Line 93: pass
Line 94:
Line 95: def addtag(self, vg, lv, tag):
Line 96: cur_tags = self.lvmd[vg][lv]['tags']
Line 97: self.lvmd[vg][lv]['tags'] = tuple(cur_tags + (tag,))
cur_tags + (tag,) should work, but why store a list of tags, so we can append the new tag?
Line 98:
Line 99: def lvPath(self, vgName, lvName):
Line 100: return os.path.join(self.root, "dev", vgName, lvName)
Line 101:
--
To view, visit https://gerrit.ovirt.org/45389
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I690ed4151428b22774415f38b350676391ccca46
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list