Change in vdsm[master]: hsm: Support checkStatus param in getDeviceList

nsoffer at redhat.com nsoffer at redhat.com
Wed Sep 2 15:34:44 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: hsm: Support checkStatus param in getDeviceList
......................................................................


Patch Set 8: Code-Review-1

(4 comments)

Few minor fixes needed.

https://gerrit.ovirt.org/#/c/45093/8/vdsm/rpc/vdsmapi-schema.json
File vdsm/rpc/vdsmapi-schema.json:

Line 1448
Line 1449
Line 1450
Line 1451
Line 1452
4.17.x - in another patch


Line 1477
Line 1478
Line 1479
Line 1480
Line 1481
4.17.x

Align with the #:

    #optional
    GUIDs ...


Line 1429: #            - a partition table is found on the device
Line 1430: #            - The device may have a mounted file system
Line 1431: #
Line 1432: # @unknown:  The device status is unknown
Line 1433: #            (new in version 4.17)
4.17.3
Line 1434: #
Line 1435: # Since: 4.10.0
Line 1436: ##
Line 1437: {'enum': 'BlockDeviceStatus', 'data': ['free', 'used', 'unknown']}


Line 1502: # @guids:        #optional Only return info on specific list of block device
Line 1503: #                 GUIDs  (new in version 4.17)
Line 1504: #
Line 1505: # @checkStatus:  #optional Indicates if device status should be checked
Line 1506: #                 (new in version 4.17)
4.17.x

Same
Line 1507: #
Line 1508: # Returns:
Line 1509: # An array of @BlockDeviceInfo
Line 1510: #


-- 
To view, visit https://gerrit.ovirt.org/45093
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic28954708f2fd7c7b721aa7f9a0fb6e1a6019597
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Fred Rolland <frolland at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list