Change in vdsm[master]: storage: Hidden files filtered form listings of storage domains

mpolednik at redhat.com mpolednik at redhat.com
Wed Sep 2 12:15:18 UTC 2015


Martin Polednik has posted comments on this change.

Change subject: storage: Hidden files filtered form listings of storage domains
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/45645/1/vdsm/storage/fileSD.py
File vdsm/storage/fileSD.py:

Line 427:         basedir = self.getIsoDomainImagesDir()
Line 428:         filesList = self.oop.simpleWalk(basedir)
Line 429: 
Line 430:         nonHiddenFilesRE = '.*/[^.][^/]*$'
Line 431:         filesList = [x for x in filesList if re.match(nonHiddenFilesRE, x)]
If I understand correctly, you can use built-in startswith method.

str.startswith(prefix[, start[, end]])
Line 432: 
Line 433:         if pattern != '*':
Line 434:             if caseSensitive:
Line 435:                 filesList = fnmatch.filter(filesList, pattern)


-- 
To view, visit https://gerrit.ovirt.org/45645
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0eebd8b9fe98c41df686330858b3292fa37ba245
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Jakub Niedermertl <jniederm at redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list