Change in vdsm[master]: v2v: Use new concurrent.thread() utility

nsoffer at redhat.com nsoffer at redhat.com
Tue Sep 1 20:26:31 UTC 2015


Nir Soffer has uploaded a new change for review.

Change subject: v2v: Use new concurrent.thread() utility
......................................................................

v2v: Use new concurrent.thread() utility

This patch updates v2v to use the new utility. No behavior change is
expected, as v2v already used @utils.traceback and daemonic thread.

Change-Id: Iae73ef21caabc88951823ef20055da5aac6f7443
Relates-To: https://bugzilla.redhat.com/1141422
Signed-off-by: Nir Soffer <nsoffer at redhat.com>
---
M vdsm/v2v.py
1 file changed, 3 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/16/45616/1

diff --git a/vdsm/v2v.py b/vdsm/v2v.py
index cdd831b..437fa86 100644
--- a/vdsm/v2v.py
+++ b/vdsm/v2v.py
@@ -36,11 +36,12 @@
 
 import libvirt
 
+from vdsm import concurrent
 from vdsm.constants import P_VDSM_RUN
 from vdsm.define import errCode, doneCode
 from vdsm import libvirtconnection, response
 from vdsm.infra import zombiereaper
-from vdsm.utils import traceback, CommandPath, execCmd, NICENESS, IOCLASS
+from vdsm.utils import CommandPath, execCmd, NICENESS, IOCLASS
 
 import caps
 
@@ -362,8 +363,7 @@
         return obj
 
     def start(self):
-        t = threading.Thread(target=self._run_command)
-        t.daemon = True
+        t = concurrent.thread(self._run_command)
         t.start()
 
     @property
@@ -393,7 +393,6 @@
         with password_file(self._id, self._passwd_file, self._password):
             self._run()
 
-    @traceback(msg="Error importing vm")
     def _run(self):
         try:
             self._import()


-- 
To view, visit https://gerrit.ovirt.org/45616
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iae73ef21caabc88951823ef20055da5aac6f7443
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>


More information about the vdsm-patches mailing list